Shifty icon indicating copy to clipboard operation
Shifty copied to clipboard

Published 20 hours ago • verified publisher icon thompsonate

Shifty fails to detect active website during full screen video in Safari

Open momenabdelkarim opened this issue 4 years ago • 2 comments

Disabling Night Shift for a website on Safari doesn't work if you're playing a video in full screen. I tested this on Youtube and Netflix. It works on Chrome though.

To reproduce:

  1. Open Safari
  2. Open any Youtube video
  3. In Shifty menu, disable Night Shift "for YouTube.com". Night Shift should turn off now.
  4. Enter full screen for the video. Night Shift is automatically re-enabled. If you open the Shifty menu you'll notice Shifty stops recognizing which website you're on in Safari.

momenabdelkarim avatar Mar 10 '20 02:03 momenabdelkarim

I have this fixed in my own branch. You can use the build in this comment if you'd like https://github.com/thompsonate/Shifty/issues/90#issuecomment-541559220 and let me know how it goes for you (it also includes some optimizations specifically for Safari). I would really want to find time to clean up and push a PR but I've been super busy.

choco avatar Mar 10 '20 12:03 choco

Is choco's branch still the only way to make fullscreen Safari work with Shifty, after two years?

zdlo avatar May 31 '22 20:05 zdlo