Tom Longhurst comments

Results 272 comments of


                                            Tom Longhurst

Extensible Test Cancellation

Not blocked. Just would provide more flexibility. I have logic around cancellation that I think could probably be tidied up if I could just cancel the master token

Extensible Test Cancellation

If I cancel my source, your source doesn't get cancelled, because I don't have access to it. So throwing a canceled exception won't bubble up properly because your handling has...

[MTP] Error when VSTest arguments are passed via old `dotnet test` when they will be ignored

The dotnet test process is being improved in .net 10 isn't it? Will the -- still be required to separate dotnet args from application args?

TestMethodIdentifierProperty *TypeFullName is not nullable

The Test Type can probably stay not-nullable, as it'll always be a named type. But copilot mentions dynamic, so I guess this? ``` public async Task DynamicTest(dynamic value) { ......

TestMethodIdentifierProperty *TypeFullName is not nullable

Also this? ``` public async Task DynamicTest(T value) { ... } ```

TestMethodIdentifierProperty *TypeFullName is not nullable

Thanks for the explanation! Another thing it's used for is displaying the test explorer. It uses the names/types/etc to determine what to show. But if we manage to get momentum...

Switched to the more performant System.Threading.Lock on .NET 9.0+

Looks good! Only thing is I'd prefer to keep the dependencies minimal. Any chance we can do a compiler if statement? If net 8 > object If net 9 >...

Switched to the more performant System.Threading.Lock on .NET 9.0+

If it doesn't bring in anything new to the package then sure!

Unnecessary and prohibiting error about `await using` on `Assert.Multiple()`

Thanks - I'll look into this. Current workaround (apart from the pragma disable) is using a scope for the using: ``` await using (Assert.Multiple()) { ... } ```

Unnecessary and prohibiting error about `await using` on `Assert.Multiple()`

I'll just make the analyzer accept both versions. I won't remove it because the dispose call is what performs the assertions, so if there's no analyzer to remind people to...