TUnit icon indicating copy to clipboard operation
TUnit copied to clipboard

remove ArgumentsAttribute constructor that always throws

Open SimonCropp opened this issue 1 year ago • 4 comments
trafficstars

SimonCropp avatar Sep 19 '24 11:09 SimonCropp

Thanks @SimonCropp - looks like there was an analyzer for this, and now a failing test so that might need to go too

thomhurst avatar Sep 19 '24 16:09 thomhurst

@thomhurst done

SimonCropp avatar Sep 21 '24 01:09 SimonCropp

well i remove the test. do i remove the analyser as well?

SimonCropp avatar Sep 21 '24 01:09 SimonCropp

well i remove the test. do i remove the analyser as well?

Tbh I wrote that analyser very early on. If it's basically redundant (because the attribute constructor is redundant) then yeah delete it.

I basically want it to throw if no arguments were provided, and it still will do that right?

thomhurst avatar Sep 21 '24 01:09 thomhurst

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Oct 25 '24 20:10 github-actions[bot]