glyphsearch icon indicating copy to clipboard operation
glyphsearch copied to clipboard

Published 20 hours ago • verified publisher icon thomaspark

Add FeatherIcons

Open CodyPChristian opened this issue 6 years ago • 5 comments

Can you add https://feathericons.com/? or I can possibly send a PR for it.

CodyPChristian avatar Aug 10 '18 17:08 CodyPChristian

Hey @CodyPChristian, looks like a nice icon set to add, but GlyphSearch is mainly set up to do font icons. You're welcome to do a PR but may require more work than expected to get svg integrated nicely.

thomaspark avatar Aug 10 '18 18:08 thomaspark

I have been waiting to add search to Icongram so I may do it this weekend, let's see 🤞

jenil avatar Aug 10 '18 18:08 jenil

@thomaspark Looks like two people have already converted it actually. https://github.com/AT-UI/feather-font https://github.com/luizbills/feather-icon-font Thoughts?

CodyPChristian avatar Aug 10 '18 22:08 CodyPChristian

@CodyPChristian, nice find. I do have two concerns though: most people will probably be using Feather as svg rather than icon font, so the usefulness of adding the icon font version is questionable. And not sure how well maintained these forks are relative to Feather itself. Might be better to work on the svg angle. What do you think?

thomaspark avatar Aug 11 '18 02:08 thomaspark

@thomaspark Hey, thanks, yeah thats a good point and makes sense actually. I was more so thinking of it spiting back the data-feather="name" attribute as it does with the other libs. However yes it is kind a blurred line due to the fact its SVG and not Icon font.

CodyPChristian avatar Aug 11 '18 22:08 CodyPChristian