ggforce icon indicating copy to clipboard operation
ggforce copied to clipboard

fix default geom for stat_sina

Open jan-glx opened this issue 5 years ago • 1 comments

jan-glx avatar Dec 12 '19 12:12 jan-glx

Currently, the default geom for stat_sina is "sina", but GeomSina is not defined. This PR changes the default to "point", so that by default stat_sina() will match the results from geom_sina() instead of throwing an error.


Example current behavior:

library(ggforce)
#> Loading required package: ggplot2
ggplot(iris, aes(x = Species, y = Sepal.Length)) + stat_sina(geom="point")

ggplot(iris, aes(x = Species, y = Sepal.Length)) + stat_sina()
#> Error: Can't find `geom` called 'sina'

Example behavior with patch:

library(ggforce)
#> Loading required package: ggplot2
ggplot(iris, aes(x = Species, y = Sepal.Length)) + stat_sina(geom="point")

ggplot(iris, aes(x = Species, y = Sepal.Length)) + stat_sina()

Created on 2022-03-04 by the reprex package (v2.0.1)

jan-glx avatar Mar 04 '22 19:03 jan-glx

🙏🙏

thomasp85 avatar Aug 16 '22 07:08 thomasp85