DirtyFX icon indicating copy to clipboard operation
DirtyFX copied to clipboard

Use ReadOnlyBooleanProperty instead of ObservableValue<Boolean>

Open daniel-shuy opened this issue 4 years ago • 0 comments

First off, thanks for this library.

This PR modifies DirtyProperty#isDirtyProperty(), DirtyBooleanProperty#originalValueProperty() to return ReadOnlyBooleanProperty instead of ObservableValue<Boolean>, and modifies CompositeDirtyProperty to extend ReadOnlyBooleanProperty instead of ObservableValue<Boolean>.

The reason for this is that ReadOnlyBooleanProperty has some useful utility methods, eg. BooleanExpression#not().

daniel-shuy avatar Mar 19 '20 12:03 daniel-shuy