DirtyFX icon indicating copy to clipboard operation
DirtyFX copied to clipboard

unbindBidirectional adds the listener instead of removing it

Open eismeraldo opened this issue 5 years ago • 2 comments

The class "DirtyStringProperty" in line 50 should be changed from: "override fun removeListener (listener: ChangeListener <in String>?) = delegate.addListener (listener)" to: "override fun removeListener (listener: ChangeListener <in String>?) = delegate.removeListener (listener)" Otherwise, the system throws the exception: "Exception in thread" JavaFX Application Thread "java.lang.RuntimeException: Should not reach here" Because I don't know Kotlin, I ask you to change this. Thank you Eismeraldo Image 6

For example, the correct behavior does not work in the case of a master detail view. Here an item can be displayed and edited in detail, then another one, then the previous one, in this case an exception is thrown.

eismeraldo avatar Dec 30 '19 19:12 eismeraldo

Hi there, thanks for catching this. I will look into fixing this tomorrow.

thomasnield avatar Jan 09 '20 04:01 thomasnield

Hi @thomasnield, is there any possibility you will fix this? I like this library. It is so easy. It is in all simple dirty classes Just I'm now dependent on this issue.

GrolarDan avatar Dec 21 '23 17:12 GrolarDan