Thomas Merz
Thomas Merz
I usually fix scripts top-down, straight forward and let some experts check/test the `shellcheck`ed version. Acceptance criteria should be that `rear` and the test-scripts are still doing what they expected...
@pcahyna , please review my PR https://github.com/rear/rear/pull/2756 Do you like one commit per changed script in the final PR or should I rebase and force-push into one single commit?
@pcahyna and @antonvoznia > * show only newly introduced problems, not all problems for a given PR. The number of ShellCheck-detected problems in current code is very high. One can...
@jsmeix > In the past I gave up on bash checking tools because the few I tested shortly produced tons of false positives so all had been useless for me...
Hi all, I want to make the following suggestion and go step-by-step before we're stuck in the "hell of bureaucracy": * implement a user-friendly github-action for shellcheck which only shecks...
We really would be faster achieve an improvement by going small(er) steps and not a single huge one with 1000s of changes. My PRs are fitting together and are solving...
BTW: I'm also on openSUSE Leap 15.3 since 12.x, but I prefer the docker-container to the SUSE repos because it's using always latest version. Leap-Repos are "sometimes" a little bit...
@jsmeix > I expected it! https://github.com/koalaman/shellcheck/wiki/SC2086 is "Double quote to prevent globbing and word splitting" > > I assume in very most cases we know that quoting is not needed...
@pcahyna I understand. But what about my suggestion and start "small"? Let us be growing with the tasks :-)
> By the way: Ok, I respect this, everything is fine for me. This was just an offer to clarify some possible misunderstandings on both sides by a talk (which...