Thomas Low
Thomas Low
I'm sorry I mixed features in one pull request. If it helps, I could revert this pull request to the last reviewed commit and add the recent changes to a...
Yes, after the user cancels the indexing, currently active batches are still being indexed. If you use `threads=4`, the currently 4 active batches are still indexed and submitted to ElasticSearch....
Changing the polling interval is a single line change, see [indexing.xhtml](https://github.com/kitodo/kitodo-production/blob/d38197ba492ff378bed8698d9f4af8f6c53b5131/Kitodo/src/main/webapp/WEB-INF/templates/includes/system/indexing.xhtml#L154). Btw, I didn't observe any performance difference for my test data. Both 1s refresh, 5s refresh and 60s refresh...
I see the problem with the log. The counts (how many objects are already indexed) should be cached instead of re-calculated multiple times when rendering and refreshing the System/Indexing page....
This will create substantial merge conflicts with #5360, which stores the comment status in ElasticSearch to be sortable.
Hi Felix, I saw your email on the community list from July. Apparently, you never got an answer. So, here are my thoughts on this, even though my experience with...
May I ask: How do we negotiate what tests are necessary and useful, and what tests are not worth the effort? There is a **huge** range of how detailed tests...
@solth Thank you for your detailed response and uploading the code coverage report. It helped a bit. > [...] we will have to define certain parts of the application where...
@oliver-stoehr I tested your pull request. Functionally, it seems to work just fine and resolves the conflicts mentioned earlier. From this perspective, the pull request is acceptable. However, I do...
Sorry. As I said in November, I really do not have any more time left for Kitodo. The review above was already made as a favor to the community.