lovelace-toggle-lock-entity-row icon indicating copy to clipboard operation
lovelace-toggle-lock-entity-row copied to clipboard

Published 20 hours ago • verified publisher icon thomasloven

"Fix" for issue #11

Open freemann opened this issue 5 years ago • 8 comments

Make overlay bigger and centre icon in new overlay.

freemann avatar Oct 13 '19 15:10 freemann

Thank you! I've been giving this plugin much too little love for far too long...

Please add the new options to the readme, and fix the missing newline at the end of the file too, and then it'll be good to merge. Maybe make the indentation consistent too, btw.

thomasloven avatar Oct 15 '19 08:10 thomasloven

Please let me know your thoughts about my last commit, hopefully its meets your requirements.

Maybe adding a hacs.json and some versioning (tags)?!

freemann avatar Oct 15 '19 12:10 freemann

Is this ok with you?

About the hacs.json, my sources tell me that there's something better than toggle-lock-entity-row coming soon, so I'd rather hold on that for a while.

thomasloven avatar Oct 15 '19 13:10 thomasloven

You got me curious....

Pull request looks good to me.

For what it's worth, here's a gif with the new unlocking delay. switchlockdelay

freemann avatar Oct 15 '19 13:10 freemann

@thomasloven your sources are wrong, I still recommend yours version as much simplier for new users to integrate - and frankly it's harder for them to get as there's no hacs.json ;-)

andriej avatar Jan 03 '20 22:01 andriej

Are they?

thomasloven avatar Jan 06 '20 21:01 thomasloven

Isn't your simplier and thus lighter if people like me need only simple lock on entity? ;-)

andriej avatar Jan 06 '20 22:01 andriej

Marginally, but restriction-card is more up to date, has more features and is available in hacs.

I see no reason to keep maintaining toggle-lock-entity-row for a subset of the functionality of restriction-card.

thomasloven avatar Jan 07 '20 08:01 thomasloven