hass-fontawesome
hass-fontawesome copied to clipboard
Remove trailing slash in custom icons path
The trailing slash prevents loading of custom icons
while I am also looking for a way to change the default path custom_icons, to a path in my /local folder (www), I can confirm the original CUSTOM_ICONS_PATH = 'custom_icons/'
does work as advertised with custom .svg icons.
@thomasloven Are you still monitoring this repo? Would you mind showing it some love and accepting some of the PR's which address these sort of issues? I'm also unable to use custom .svg's using the instructions you provided. Thank you.
@cascer1 and @Mariusthvdb
This is the only line I've changed in my __init__.py
:
CUSTOM_ICONS_PATH = 'custom_icons'
But, I'm still not able to use custom icons placed in that folder. Did you have to do anything else to get this to work?
Also, it doesn't seem that @thomasloven is maintaining this Repo anymore. Any interest in forking it and accepting the multiple outstanding PRs? Thanks
I must admit that I'm no longer using this integration, so I probably won't be the best person to maintain a fork.
@cascer1 What are you using instead for custom icons?
depending in your requirements, you might able to use my custom_icons, see my repo. there's a CC allowing you to drop in any svg, and a custom-card that has icons builtin. persoanlly I like the CC best. It's a plain fork of Thomas's repo, without the options for fontawesome
@cascer1 What are you using instead for custom icons?
I use https://github.com/arallsopp/hass-hue-icons for some icons for my lights, and otherwise don't need custom icons currently.
I cannot reproduce this issue...
I was about to add "...but it also doesn't hurt..." and just merge this. But then I actually tested it, and MY WHOLE COMPUTER IMMEDIATELY CRASHED. I kid you not.
Merged!