hass-browser_mod icon indicating copy to clipboard operation
hass-browser_mod copied to clipboard

mobile popup fix for HA 2023.7.3

Open raymercury opened this issue 1 year ago • 14 comments

#606 #617 Around 2023.7.3 mobile popups got really longgggg. Happens for iOS, android, and web browser.

fix

raymercury avatar Jul 25 '23 05:07 raymercury

This is not working for me @raymercury. I edited /config/custom_components/browser_mod/browser_mod.js with the correct code as listed by the changes on github and this has had no effect on my popup bug.

Let me know if I'm doing this wrong. Thanks

ve1koz111 avatar Aug 06 '23 07:08 ve1koz111

@ve1koz111 I think modifying the existing JS file doesn't work. You may need to install a modified version of browser_mod integration using HACS.

Use HACS to install a test version which includes the fix: Uninstall current instance of browser_mod, clicking "ignore". Add my fork of browser_mod as a custom repository and install it, then reboot HA.

raymercury avatar Aug 12 '23 14:08 raymercury

@raymercury Thanks so much for fixing this bug, it was driving me bonkers!

shlomki avatar Sep 02 '23 10:09 shlomki

@raymercury Thanks so much!

ogoncalves200874 avatar Sep 22 '23 13:09 ogoncalves200874

@thomasloven can we get this PR merged ?

andyblac avatar Oct 03 '23 18:10 andyblac

Uninstalled in HACS, uninstalled in Devices and services. Installed your repository, and after restart installed in devices and services. Still with the size issue. Maybe i'm doing something wrong. Can you help me @raymercury ?

cikaybe avatar Oct 27 '23 11:10 cikaybe

Fix is working great. Is it possible to merge it please?

ciddi89 avatar Jan 24 '24 09:01 ciddi89

:+1:

psi-4ward avatar Jan 25 '24 12:01 psi-4ward

@thomasloven could you please merge this pr to solve our problem? Thank you!

csszokolai avatar Mar 29 '24 22:03 csszokolai

This would make the popup look different from native Home Assistant popups, like the more-info dialog.

thomasloven avatar Jul 31 '24 20:07 thomasloven

This would make the popup look different from native Home Assistant popups, like the more-info dialog.

Yeah but thats what some ppl want instead of a popup card which use 100% height ^^ maybe you can add it with a Option in the Settings so people can decide which style they want? Full-Screen or the Smaller one

Spegeli avatar Aug 02 '24 10:08 Spegeli

@thomasloven: I see what you mean, but all I want is browser_mod to respect its own size/style options, as mentioned in #639 The default might as well stay as it is.

Soukyuu avatar Aug 02 '24 12:08 Soukyuu

@thomasloven I think this is needed. I did it manually for now otherwise my wife rejected my latest home changes... She's a tough reviewer...

yosilevy avatar Sep 05 '24 07:09 yosilevy