hass-browser_mod icon indicating copy to clipboard operation
hass-browser_mod copied to clipboard

Can not click out of popup on iOS app

Open Mariusthvdb opened this issue 1 year ago • 27 comments

My Home Assistant version: 0.XX.X

What I am doing: opening a markdown popup

What I expected to happen: have some way of clicking out of the popup

What happened instead:

cant click out, not even swipe in another view, can only completely swipe the app out of Phone, and reload

Minimal steps to reproduce:

# The least amount of code or steps possible to reproduce my error
hold_action:
  action: fire-dom-event
  browser_mod:
    service: browser_mod.popup
    data:
#      style: |
 #       --popup-border-radius: 0px;
 #       --popup-padding-x: 0px;
 #       --popup-padding-y: 0px;
 #       --dialog-backdrop-filter: blur(0.8em) brightness(1.2);
 #       --dialog-content-padding: 20px;
      content:
        type: markdown
# Put your code/steps here

Error messages from the browser console:

no errors

// Select everything from the browser console and copy it

// Paste it here

image

By replacing the space in the checkboxes ([ ]) with an X below, I indicate that I:

  • [X] Understand that this is a channel for reporting bugs, not a support forum (https://community.home-assistant.io/).

  • [X ] Have made sure I am using the latest version of the plugin.

  • [X ] Have followed the troubleshooting steps of the "Common Problems" section of https://github.com/thomasloven/hass-config/wiki/Lovelace-Plugins.

  • [X ] Understand that leaving one or more boxes unticked or failure to follow the template above may increase the time required to handle my bug-report, or cause it to be closed without further action.

Mariusthvdb avatar Jul 22 '23 10:07 Mariusthvdb

I can confirm this is happening for me as well. It started happening after updating HomeAssistant to 2023.7.3.

csudderth avatar Jul 23 '23 12:07 csudderth

Same for me after updating to 2023.7.3

In case it matters, this only happens on my iOS app on the phone...it works fine on my iPad.

tm24fan8 avatar Jul 23 '23 17:07 tm24fan8

Happens for me aswell. Even on IOS and Android

Lux315 avatar Jul 23 '23 18:07 Lux315

A temporary and not optimal fix, is to install card_mod and add the following to your popup cards: (For IOS, haven't yet tested on android)

card_mod:
  style: |
    ha-dialog {
      --mdc-dialog-min-height: 10px !important;
    }

This returns the popups to a small size however, they are now at the bottom of the screen. I haven't yet figured out how to move them back up, but at least you don't have to quit the app to close a popup (This should help until a proper fix is implemented).

Example of full popup card:

type: custom:popup-card
title: Custom popup
dismissable: true
card:
  type: markdown
  content: This replaces the more-info dialog
right_button: right
left_button: left
entity: input_button.battery
card_mod:
  style: |
    ha-dialog {
      --mdc-dialog-min-height: 10px !important;
    }

roderik-maker avatar Aug 07 '23 19:08 roderik-maker

+1 same problem

YvesZH avatar Aug 10 '23 22:08 YvesZH

card_mod:
  style: |
    ha-dialog {
      --mdc-dialog-min-height: 10px !important;
    }

unfortunately does not work for ios

YvesZH avatar Aug 10 '23 22:08 YvesZH

Ive bee able to fix it the problem is in browser_mod.js and browser_mod.js.gz on media querry 450px you should change it to this:

@media all and (max-width: 450px), all and (max-height: 500px) { ha-dialog { --mdc-dialog-min-width: 97vw; --mdc-dialog-max-width: 97vw; --mdc-dialog-min-height: 10%; --mdc-dialog-max-height: 100%; } then delete cache

i leave the files if someone does not know how to edit them, just delete the ones from custom_components/browser_mod/

and replace this 2

dont know how to edit in github if someone knows please upload them so they are kept in next update browser_mod.zip

jbrandek avatar Aug 10 '23 22:08 jbrandek

@jbrandek I've tried this it does not fix it for IOS. Did this fix it for you?

ve1koz111 avatar Aug 11 '23 04:08 ve1koz111

@jbrandek I've tried this it does not fix it for IOS. Did this fix it for you?

Did you wipe the cache?

jbrandek avatar Aug 11 '23 05:08 jbrandek

Yes multiple times.

I've found a way to fix it on PC and mobile (when you inspect element and change to mobile) but unfortunately this does not fix my issue on IOS, even though I've deleted frontend cache multiple times.

https://github.com/ve1koz111/hass-browser_mod

ve1koz111 avatar Aug 11 '23 05:08 ve1koz111

Starnge, it fixes for me but im an android user, didnt try on iphone, dont know witch querry it uses... but try the full screen one the one that is before de 450px to see if that fixes it

jbrandek avatar Aug 11 '23 06:08 jbrandek

@jbrandek

https://github.com/thomasloven/hass-browser_mod/compare/master...ve1koz111:hass-browser_mod:master

I've changed everything possible

ve1koz111 avatar Aug 11 '23 06:08 ve1koz111

@jbrandek

https://github.com/thomasloven/hass-browser_mod/compare/master...ve1koz111:hass-browser_mod:master

I've changed everything possible

You also changed the js.gz one?

jbrandek avatar Aug 11 '23 06:08 jbrandek

I thought that’s created when it’s downloaded by HACS it’s not part of the code? Where can I find the compressed files?

ve1koz111 avatar Aug 11 '23 06:08 ve1koz111

I thought that’s created when it’s downloaded by HACS it’s not part of the code? Where can I find the compressed files?-- Mina Saweris

I upload them, you can compress the js wit an online gz compress tool i find it in google... try with the files i sent in the first message

jbrandek avatar Aug 11 '23 06:08 jbrandek

Same problem for me, iOS 16.6, @roderik-maker s workaround didn't help

Alex-joomla avatar Aug 13 '23 09:08 Alex-joomla

I've fixed this and confirmed it on my own ios 16.6 HA 2023.8.2

Add https://github.com/ve1koz111/hass-browser_mod as a custom repository.

Uninstall old browser mod 'ignoring' entities, and reinstall from this repository until a proper fix is made.

YOU MUST RESET FRONTEND CACHE ON YOUR DEVICE FOR THIS TO WORK.

If rounded corners are not working for you add this to your CSS:

--ha-dialog-border-radius: var(--popup-border-radius, 28px);

@Alex-joomla @jbrandek

ve1koz111 avatar Aug 14 '23 02:08 ve1koz111

I've fixed this and confirmed it on my own ios 16.6 HA 2023.8.2

Add https://github.com/ve1koz111/hass-browser_mod as a custom repository.

Uninstall old browser mod 'ignoring' entities, and reinstall from this repository until a proper fix is made.

YOU MUST RESET FRONTEND CACHE ON YOUR DEVICE FOR THIS TO WORK.

If rounded corners are not working for you add this to your CSS:

--ha-dialog-border-radius: var(--popup-border-radius, 28px);

@Alex-joomla @jbrandek

Worked for me. Thanks!

Simonh98 avatar Aug 14 '23 09:08 Simonh98

@ve1koz111 tried but no effect (cleared cache):

IMG_2305

Alex-joomla avatar Aug 14 '23 09:08 Alex-joomla

@Alex-joomla

Please let me know of the steps you followed to install this version

Thanks

ve1koz111 avatar Aug 14 '23 10:08 ve1koz111

Than you for your quick reply, i went to HACS, deinstalled the original browser-mod (hit ignore), then added your repo and installed it. Then I cleared my browser cache on my iPhone (Debug Menu)

Alex-joomla avatar Aug 14 '23 10:08 Alex-joomla

Now it works, I did nothing else :-)

Thank you, you saved our i Home :-)

Alex-joomla avatar Aug 14 '23 10:08 Alex-joomla

I've fixed this and confirmed it on my own ios 16.6 HA 2023.8.2

Add https://github.com/ve1koz111/hass-browser_mod as a custom repository.

Uninstall old browser mod 'ignoring' entities, and reinstall from this repository until a proper fix is made.

YOU MUST RESET FRONTEND CACHE ON YOUR DEVICE FOR THIS TO WORK.

If rounded corners are not working for you add this to your CSS:

--ha-dialog-border-radius: var(--popup-border-radius, 28px);

@Alex-joomla @jbrandek

Works for me. Appreciate it!

tm24fan8 avatar Aug 18 '23 03:08 tm24fan8

31 October and no fix for this, I wonder if this project is still on. Should we look for alternatives ?

danielducu avatar Oct 31 '23 08:10 danielducu

Hey, I still have the same problem on my android app, but unfortunatly I can't add your repository as it isn't structure v5.0 complaint.

Error message: <Plugin ve1koz111/hass-browser_mod> Repository structure for v5.0 is not compliant

se7entynine avatar Jan 19 '24 03:01 se7entynine

Hey, I still have the same problem on my android app, but unfortunatly I can't add your repository as it isn't structure v5.0 complaint.

Error message: <Plugin ve1koz111/hass-browser_mod> Repository structure for v5.0 is not compliant

This project has fallen into the void unfortunately. Check out bubble card , it's flawless.

danielducu avatar Jan 19 '24 05:01 danielducu

for me it stopped working recently, not since half a year, but it also doesn't work on my browser on IOS. so maybe It's an IOS(webkit) issue?

bkbartk avatar Jan 23 '24 19:01 bkbartk