hass-browser_mod icon indicating copy to clipboard operation
hass-browser_mod copied to clipboard

Popup is stretched to the entire window in the android app home assistant

Open andrey170183 opened this issue 1 year ago • 20 comments

My Home Assistant version: 2023.7.2

What I am doing: Updated browser_mod to version 2.3.0

What I expected to happen: Open in a small window as before before the update

What happened instead: popup opened for the whole window in the android app home assistant

Minimal steps to reproduce: Just updated browser_mod to version 2.3.0 Screenshot_20230715-190309149

andrey170183 avatar Jul 15 '23 10:07 andrey170183

Same on iPhone

WW1983 avatar Jul 16 '23 12:07 WW1983

Same here (Android 13)

K-RAD avatar Jul 17 '23 15:07 K-RAD

same here..

limitless00net avatar Jul 18 '23 23:07 limitless00net

Me too - iPhone. Have tried pretty much everything (I think) - style changes, size changes as per documentation, theme changes, clear cache.

rob-oravec avatar Jul 21 '23 03:07 rob-oravec

I'm having the same problem too. (iPhone14Pro iOS17, iPhone11Pro iOS16)

Namsikjo avatar Jul 23 '23 08:07 Namsikjo

Got this issue aswell.

Seems to be the same issue like here: https://github.com/thomasloven/hass-browser_mod/issues/617

@thomasloven Could you please take a look?

Lux315 avatar Jul 23 '23 18:07 Lux315

same issue for me on Android (Pixel 7 pro) & iPhone (14 pro max). Seems to be working fine on iPad & PC/Mac.

suheilpurewal avatar Jul 23 '23 20:07 suheilpurewal

same issue for me on Android (Pixel 7 pro) & iPhone (14 pro max). Seems to be working fine on iPad & PC/Mac.

True, it affects popups on mobiles only. Basically devices that show the default more-info dialogs in a window are unaffected. Devices that show the more-info dialogs in a fullscreen manner (the core dialogs) now also show browser_mod popups in fullscreen (with a bugged out header).

ASNNetworks avatar Jul 29 '23 19:07 ASNNetworks

A temporary and not optimal fix, is to install card_mod and add the following to your popup cards: (For IOS, haven't yet tested on android)

card_mod:
  style: |
    ha-dialog {
      --mdc-dialog-min-height: 10px !important;
    }

This returns the popups to a small size however, they are now at the bottom of the screen. I haven't yet figured out how to move them back up, but at least you don't have to quit the app to close a popup (This should help until a proper fix is implemented).

Example of full popup card:

type: custom:popup-card
title: Custom popup
dismissable: true
card:
  type: markdown
  content: This replaces the more-info dialog
right_button: right
left_button: left
entity: input_button.battery
card_mod:
  style: |
    ha-dialog {
      --mdc-dialog-min-height: 10px !important;
    }

roderik-maker avatar Aug 07 '23 19:08 roderik-maker

Ive bee able to fix it the problem is in browser_mod.js and browser_mod.js.gz on media querry 450px you should change it to this:

@media all and (max-width: 450px), all and (max-height: 500px) { ha-dialog { --mdc-dialog-min-width: 97vw; --mdc-dialog-max-width: 97vw; --mdc-dialog-min-height: 10%; --mdc-dialog-max-height: 100%; } then delete cache

i leave the files if someone does not know how to edit them, just delete the ones from custom_components/browser_mod/

and replace this 2

dont know how to edit in github if someone knows please upload them so they are kept in next update browser_mod.zip

jbrandek avatar Aug 10 '23 22:08 jbrandek

THX! Works on IOS!

Razzer90 avatar Aug 11 '23 16:08 Razzer90

#617 Fix at the bottom

ve1koz111 avatar Aug 14 '23 12:08 ve1koz111

I too have this issue. And I've tried the mentioned solutions to no avail. I'm on Android app on a OnePlus 9 Pro.

What it looked like: Screenshot_2023-09-12-15-54-35-29_b72a20be883aec8a014bd2b7c7038e87

What it looks like now: Screenshot_2023-09-12-15-54-24-69_c3a231c25ed346e59462e84656a70e50

smeen89 avatar Sep 12 '23 13:09 smeen89

@smeen89 https://github.com/thomasloven/hass-browser_mod/issues/617#issuecomment-1676580513

ve1koz111 avatar Sep 13 '23 03:09 ve1koz111

@ve1koz111

You beautiful magician! This has been bugging me for so long and now it works! Great job!

smeen89 avatar Sep 15 '23 07:09 smeen89

@ve1koz111 thank you so much for your fix. I tried it and works just like it should :) Hopefully @thomasloven will merge with the official.

ASNNetworks avatar Oct 05 '23 14:10 ASNNetworks

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 15 '23 06:12 stale[bot]

this is still an issue, replacing the files did not do the trick for me

JoaoPedro13 avatar Feb 14 '24 21:02 JoaoPedro13

Could someone please post a screenshot of what the normal non-browser_mod more-info dialog popup looks like on the android app?

thomasloven avatar Feb 17 '24 10:02 thomasloven

@thomasloven 1st one is BM Screenshot_20240219-171224 Screenshot_20240219-171349 Screenshot_20240219-171422 Screenshot_20240219-171522

Dino-Tech avatar Feb 19 '24 23:02 Dino-Tech