hass-browser_mod icon indicating copy to clipboard operation
hass-browser_mod copied to clipboard

with latest version more info is being shown as well as popup card...nothing else changed

Open jouster1974 opened this issue 3 years ago • 51 comments

installed Browser mode latest changes today and now popup cards setup yesterday also show the more-info dialog box when they didn't before.

have also installed 2022.9 so this could be a combo issue but thought I would mention it just in case but it was working fine on prior release of Core

jouster1974 avatar Sep 07 '22 21:09 jouster1974

I have the same problem, definitely happened after upgrading to 2022.9. The standard more info and the pop up both show up, and I have to close the standard one before operating with the pop up. Edit: this seems a problem only on the official app: if I log in via browser on the same phone all works fine; also on PC it works fine. The app on both an Android phone and an Apple iPad has the problem.

tigers75 avatar Sep 08 '22 06:09 tigers75

I have the same problem about pop up...not showed

CelestinoMarini avatar Sep 08 '22 06:09 CelestinoMarini

I have the same problem about pop up...not showed

If it's not showing then it's not the same problem: for me the pop up shows up both together with the standard more info window

tigers75 avatar Sep 08 '22 06:09 tigers75

same problem

neutrondev20 avatar Sep 08 '22 07:09 neutrondev20

I've wound back to me Pre 2022.9 backup and all working as it was....

jouster1974 avatar Sep 08 '22 14:09 jouster1974

Can confirm that reverting back to 2022.8 solved the problem, that showed up also on PC (maybe I didn't refresh the cache correctly - I did a CTRL+F5 refresh but still...). Hope it's fixable, I just discovered the pop-ups and was starting to adopt them.

tigers75 avatar Sep 08 '22 15:09 tigers75

Same problem here after updating to 2022.9

holdestmade avatar Sep 09 '22 08:09 holdestmade

Same problem after updating to 2022.9.1 from 2022.8.7 however what is interesting is I have pop-ups that work without the more-info and popups that cause a more-info pop-up on top of the regular popup.

It seems to be an issue with nested pop-ups for me.

https://user-images.githubusercontent.com/47092714/189319953-7498efbc-83aa-4d61-9355-b9878649cc21.mp4

Below is the code for the pop-up without issues and the nested pop-up that only works on the first More pop-up and any of the sub pop-ups result in a more-info dialog. Can't attach a .yaml so here's a .txt Popup Issue.txt

Frontend PRs that could be related: https://github.com/home-assistant/frontend/pull/13416 https://github.com/home-assistant/frontend/pull/13425

Daniel-dev22 avatar Sep 09 '22 09:09 Daniel-dev22

If I understand correctly you have a pop-up card activated by a browser event, while I'm experiencing the problem on a pop-up card defined "as a card" with the new 2.0, maybe that's the difference?

tigers75 avatar Sep 09 '22 10:09 tigers75

If I understand correctly you have a pop-up card activated by a browser event, while I'm experiencing the problem on a pop-up card defined "as a card" with the new 2.0, maybe that's the difference?

I think it's more to do with changes in the frontend

It appears there's also issues with calling popups from the backend through a service. My tablet also has the more-info pop-up

Daniel-dev22 avatar Sep 09 '22 10:09 Daniel-dev22

I agree: the vanilla more-info pop has significantly changed in this version.

tigers75 avatar Sep 12 '22 07:09 tigers75

What browser mod versions is everything using with this issue?

Anyone using browser mod 2?

Daniel-dev22 avatar Sep 13 '22 12:09 Daniel-dev22

What browser mod versions is everything using with this issue?

Anyone using browser mod 2?

Yes, v2

holdestmade avatar Sep 13 '22 12:09 holdestmade

What browser mod versions is everything using with this issue? Anyone using browser mod 2?

Yes, v2

Can you post your yaml of the pop-up code you're using and a screen recording to demonstrate the issue? It will help Thomas troubleshoot.

Daniel-dev22 avatar Sep 13 '22 12:09 Daniel-dev22

So I have a popups.yaml file, this is the 1st part of it with 3 popups:

type: vertical-stack
cards:
  - type: custom:popup-card
    entity: alarm_control_panel.home
    title: Alarm
    card:
      type: vertical-stack
      cards:
        - type: horizontal-stack
          cards:
            - type: "custom:button-card"
              entity: binary_sensor.alarm_sensors_armed_away
              show_name: false
              show_entity_picture: true
              entity_picture: /local/images/icons8-home-alarm-armed-day-clear.png
              size: 30%
              tap_action:
                action: more-info
              state:
                - value: "on"
                  entity_picture: /local/images/icons8-home-alarm-armed-day-active.png
            - type: "custom:button-card"
              entity: binary_sensor.alarm_sensors_armed_night
              show_name: false
              show_entity_picture: true
              entity_picture: /local/images/icons8-home-alarm-armed-night-clear.png
              size: 30%
              tap_action:
                action: more-info
              state:
                - value: "on"
                  entity_picture: /local/images/icons8-home-alarm-armed-night-active.png
        - type: alarm-panel
          entity: alarm_control_panel.home
          states:
            - arm_away
            - arm_night

  - type: custom:popup-card
    entity: switch.filament_dryer
    title: Filament Dryer
    card:
      type: vertical-stack
      cards:
        - type: entities
          show_header_toggle: false
          entities:
            - entity: switch.filament_dryer
              name: Power
            - entity: input_boolean.filament_dryer_start
              name: Timer Start
              state_color: true
            - entity: input_number.filament_dryer_duration
              name: Timer Duration
            - type: custom:timer-bar-card
              entity: timer.filament_dryer_duration
              name: Timer
              state_color: true
              bar_direction: rtl
              bar_foreground: "#808080"
              bar_background: "var(--mdc-theme-primary, #6200ee)"
              text_width: 4em
            - entity: sensor.filament_dryer_temperature
              name: Temperature
            - entity: sensor.filament_dryer_status
              name: State
            - entity: sensor.filament_dryer_voltage
              name: Electricity
              state_header: Voltage
              type: custom:multiple-entity-row
              entities:
                - entity: sensor.filament_dryer_current
                  name: Current
                - entity: sensor.filament_dryer_power
                  name: Power
            - entity: sensor.filament_dryer_total_daily_energy
              name: Today
              state_header: Energy
              type: custom:multiple-entity-row
              entities:
                - entity: sensor.filament_dryer_total_daily_cost
                  name: Cost

  - type: custom:popup-card
    entity: light.landing_light
    title: Landing Light
    card:
      type: vertical-stack
      cards:
        - type: custom:light-entity-card
          entity: light.landing_light
          persist_features: true
          full_width_sliders: true
          header: Light
        - type: entities
          entities:
            - entity: input_boolean.landing_automations
              name: Automations

Then in my dashboard view:

views:
  - title: Home
    icon: "mdi:home"
    panel: true
    #path: default_view
    cards:
      - type: vertical-stack
        cards:
          - type: grid
            columns: 4
            square: false
            cards:
              - type: vertical-stack
                cards:
                  - !include dashboard-components/weather.yaml
                  - !include dashboard-components/people.yaml
                  - !include dashboard-components/air_quality.yaml
                  - !include dashboard-components/security.yaml
                  - !include dashboard-components/bins.yaml
                  #- !include dashboard-components/christmas.yaml
                  - !include dashboard-components/alexa_next.yaml
              - type: vertical-stack
                cards:
                  - !include dashboard-components/garden_front.yaml
                  - !include dashboard-components/garden_back.yaml
                  - !include dashboard-components/garage.yaml
                  - !include dashboard-components/workshop.yaml
              - type: vertical-stack
                cards:
                  - !include dashboard-components/living_room.yaml
                  - !include dashboard-components/kitchen.yaml
                  - !include dashboard-components/utility.yaml
                  - !include dashboard-components/toilet.yaml
                  - !include dashboard-components/hall.yaml
                  - !include dashboard-components/landing.yaml
              - type: vertical-stack
                cards:
                  - !include dashboard-components/bedroom.yaml
                  - !include dashboard-components/alices_room.yaml
                  - !include dashboard-components/bens_room.yaml
                  - !include dashboard-components/guest_bedroom.yaml
                  - !include dashboard-components/ensuite.yaml
                  - !include dashboard-components/bathroom.yaml
                  - !include dashboard-components/popups.yaml
          - type: vertical-stack
            cards:
              - !include dashboard-components/cameras.yaml
              - !include dashboard-components/popups.yaml

When I click on a an entity, the more-info popup shows at the top and the browser_mod popup shows up in the centre over the more-info. Escape closes both windows

holdestmade avatar Sep 13 '22 12:09 holdestmade

So I have a popups.yaml file, this is the 1st part of it with 3 popups:

type: vertical-stack
cards:
  - type: custom:popup-card
    entity: alarm_control_panel.home
    title: Alarm
    card:
      type: vertical-stack
      cards:
        - type: horizontal-stack
          cards:
            - type: "custom:button-card"
              entity: binary_sensor.alarm_sensors_armed_away
              show_name: false
              show_entity_picture: true
              entity_picture: /local/images/icons8-home-alarm-armed-day-clear.png
              size: 30%
              tap_action:
                action: more-info
              state:
                - value: "on"
                  entity_picture: /local/images/icons8-home-alarm-armed-day-active.png
            - type: "custom:button-card"
              entity: binary_sensor.alarm_sensors_armed_night
              show_name: false
              show_entity_picture: true
              entity_picture: /local/images/icons8-home-alarm-armed-night-clear.png
              size: 30%
              tap_action:
                action: more-info
              state:
                - value: "on"
                  entity_picture: /local/images/icons8-home-alarm-armed-night-active.png
        - type: alarm-panel
          entity: alarm_control_panel.home
          states:
            - arm_away
            - arm_night

  - type: custom:popup-card
    entity: switch.filament_dryer
    title: Filament Dryer
    card:
      type: vertical-stack
      cards:
        - type: entities
          show_header_toggle: false
          entities:
            - entity: switch.filament_dryer
              name: Power
            - entity: input_boolean.filament_dryer_start
              name: Timer Start
              state_color: true
            - entity: input_number.filament_dryer_duration
              name: Timer Duration
            - type: custom:timer-bar-card
              entity: timer.filament_dryer_duration
              name: Timer
              state_color: true
              bar_direction: rtl
              bar_foreground: "#808080"
              bar_background: "var(--mdc-theme-primary, #6200ee)"
              text_width: 4em
            - entity: sensor.filament_dryer_temperature
              name: Temperature
            - entity: sensor.filament_dryer_status
              name: State
            - entity: sensor.filament_dryer_voltage
              name: Electricity
              state_header: Voltage
              type: custom:multiple-entity-row
              entities:
                - entity: sensor.filament_dryer_current
                  name: Current
                - entity: sensor.filament_dryer_power
                  name: Power
            - entity: sensor.filament_dryer_total_daily_energy
              name: Today
              state_header: Energy
              type: custom:multiple-entity-row
              entities:
                - entity: sensor.filament_dryer_total_daily_cost
                  name: Cost

  - type: custom:popup-card
    entity: light.landing_light
    title: Landing Light
    card:
      type: vertical-stack
      cards:
        - type: custom:light-entity-card
          entity: light.landing_light
          persist_features: true
          full_width_sliders: true
          header: Light
        - type: entities
          entities:
            - entity: input_boolean.landing_automations
              name: Automations

Then in my dashboard view:

views:
  - title: Home
    icon: "mdi:home"
    panel: true
    #path: default_view
    cards:
      - type: vertical-stack
        cards:
          - type: grid
            columns: 4
            square: false
            cards:
              - type: vertical-stack
                cards:
                  - !include dashboard-components/weather.yaml
                  - !include dashboard-components/people.yaml
                  - !include dashboard-components/air_quality.yaml
                  - !include dashboard-components/security.yaml
                  - !include dashboard-components/bins.yaml
                  #- !include dashboard-components/christmas.yaml
                  - !include dashboard-components/alexa_next.yaml
              - type: vertical-stack
                cards:
                  - !include dashboard-components/garden_front.yaml
                  - !include dashboard-components/garden_back.yaml
                  - !include dashboard-components/garage.yaml
                  - !include dashboard-components/workshop.yaml
              - type: vertical-stack
                cards:
                  - !include dashboard-components/living_room.yaml
                  - !include dashboard-components/kitchen.yaml
                  - !include dashboard-components/utility.yaml
                  - !include dashboard-components/toilet.yaml
                  - !include dashboard-components/hall.yaml
                  - !include dashboard-components/landing.yaml
              - type: vertical-stack
                cards:
                  - !include dashboard-components/bedroom.yaml
                  - !include dashboard-components/alices_room.yaml
                  - !include dashboard-components/bens_room.yaml
                  - !include dashboard-components/guest_bedroom.yaml
                  - !include dashboard-components/ensuite.yaml
                  - !include dashboard-components/bathroom.yaml
                  - !include dashboard-components/popups.yaml
          - type: vertical-stack
            cards:
              - !include dashboard-components/cameras.yaml
              - !include dashboard-components/popups.yaml

When I click on a an entity, the more-info popup shows at the top and the browser_mod popup shows up in the centre over the more-info. Escape closes both windows

How about on mobile? What happens?

Daniel-dev22 avatar Sep 13 '22 12:09 Daniel-dev22

It doesn't happen on my mobile (android).

holdestmade avatar Sep 13 '22 13:09 holdestmade

https://drive.google.com/file/d/1rjPi07LK2jo6gCHE4S9GikrPYJbtQrX2/view?usp=sharing

holdestmade avatar Sep 13 '22 13:09 holdestmade

It doesn't happen on my mobile (android).

It does both on my mobile Android and on iPad (latest iOS). I'm using the official app on both. Still I don't understand if someone is NOT experiencing this issue: I see no reply after 8 days and it seems quite a big bug to me.

tigers75 avatar Sep 15 '22 11:09 tigers75

It doesn't happen on my mobile (android).

It does both on my mobile Android and on iPad (latest iOS). I'm using the official app on both. Still I don't understand if someone is NOT experiencing this issue: I see no reply after 8 days and it seems quite a big bug to me.

What browser mod version are you on?

I talked to Thomas (browser mod developer) a few days ago on discord. He mentioned browser mod always tried to close the more-info pop-up as fast as possible. The more-info pop-up has likely become significantly faster and browser mod may need to be modified to fix it. Could be simple, could be complicated.

Daniel-dev22 avatar Sep 15 '22 11:09 Daniel-dev22

He mentioned browser mod always tried to close the more-info pop-up as fast as possible. The more-info pop-up has likely become significantly faster and browser mod may need to be modified to fix it. Could be simple, could be complicated.

Is it maybe because the more-info box is now at the top of the screen ? It might have been there before but under the popup card ? Maybe the browser-mod popup card could be moved to the top as well ?

holdestmade avatar Sep 15 '22 11:09 holdestmade

He mentioned browser mod always tried to close the more-info pop-up as fast as possible. The more-info pop-up has likely become significantly faster and browser mod may need to be modified to fix it. Could be simple, could be complicated.

Is it maybe because the more-info box is now at the top of the screen ? It might have been there before but under the popup card ? Maybe the browser-mod popup card could be moved to the top as well ?

That's potentially the case for desktop. For mobile I think they are in the same area

Daniel-dev22 avatar Sep 15 '22 11:09 Daniel-dev22

I don't have the issue on mobile, I know @tigers75 does though

holdestmade avatar Sep 15 '22 11:09 holdestmade

He mentioned browser mod always tried to close the more-info pop-up as fast as possible. The more-info pop-up has likely become significantly faster and browser mod may need to be modified to fix it. Could be simple, could be complicated.

Is it maybe because the more-info box is now at the top of the screen ? It might have been there before but under the popup card ? Maybe the browser-mod popup card could be moved to the top as well ?

I don't think that's the problem, or at least it's not the only one: the original more-info pop up is on the background visually but it has focus (this means I can't click anything on the browser_mod popup even if it's on top, but I can click on the contents of the "original" more-info even if it's behind.

tigers75 avatar Sep 15 '22 13:09 tigers75

It doesn't happen on my mobile (android).

It does both on my mobile Android and on iPad (latest iOS). I'm using the official app on both. Still I don't understand if someone is NOT experiencing this issue: I see no reply after 8 days and it seems quite a big bug to me.

What browser mod version are you on?

I talked to Thomas (browser mod developer) a few days ago on discord. He mentioned browser mod always tried to close the more-info pop-up as fast as possible. The more-info pop-up has likely become significantly faster and browser mod may need to be modified to fix it. Could be simple, could be complicated.

I don't know, but if he came here we could help in in debugging the problem, on ourselves we are pretty much playing guess games...

tigers75 avatar Sep 15 '22 13:09 tigers75

It doesn't happen on my mobile (android).

It does both on my mobile Android and on iPad (latest iOS). I'm using the official app on both. Still I don't understand if someone is NOT experiencing this issue: I see no reply after 8 days and it seems quite a big bug to me.

What browser mod version are you on? I talked to Thomas (browser mod developer) a few days ago on discord. He mentioned browser mod always tried to close the more-info pop-up as fast as possible. The more-info pop-up has likely become significantly faster and browser mod may need to be modified to fix it. Could be simple, could be complicated.

I don't know, but if he came here we could help in in debugging the problem, on ourselves we are pretty much playing guess games...

He told me browser mod version could matter. That's why I asked what version you're on? I didn't migrate yet to 2.0.

Daniel-dev22 avatar Sep 15 '22 13:09 Daniel-dev22

I believe it's in the title: we are talking about latest version of browser_mod (that's 2.1.3 at the moment to be clear, but it was the same with all 2.x releases) properly configured and working fine in HA 2022.8.x but broken in HA 2022.9.x

tigers75 avatar Sep 15 '22 13:09 tigers75

the original more-info pop up is on the background visually but it has focus (this means I can't click anything on the browser_mod popup even if it's on top, but I can click on the contents of the "original" more-info even if it's behind.

Strange, I can click on either the pop up card or the more-info card and the both respond to clicks (see the video capture above)

holdestmade avatar Sep 15 '22 15:09 holdestmade

This is what happens to me (on PC in a Chrome tab): I can click freely on the original pop-up, the first clic on the browser_mod pop-up closes the original more-info and only the second click has effect on the pop-up card.

Browser_mod_popup

tigers75 avatar Sep 15 '22 16:09 tigers75

Just to add some more info I noticed that sometimes it starts to work as intended from the same machine I took the video in my previous message. I'll try to isolate the conditions, I noticed it now as the PC just waked from sleep mode, don't know if that's relevant, will investigate.

tigers75 avatar Sep 17 '22 10:09 tigers75