Slackord icon indicating copy to clipboard operation
Slackord copied to clipboard

Add Slack Thread support

Open thomasloupe opened this issue 3 years ago • 7 comments

Currently, Slackord2 does not have thread support, so all messages are placed individually. Support Slack threads and convert threaded conversations to Discord threads where they exist.

thomasloupe avatar Sep 03 '22 17:09 thomasloupe

What kind of help are you looking for for this?

jarommadsen avatar Sep 07 '22 02:09 jarommadsen

If it's helpful, the way that Slack threads work is they use the thread_ts property which is set to the parent message's ts property.

jarommadsen avatar Sep 07 '22 03:09 jarommadsen

Specifically, I don't have the time right now to get it done programmatically. It will be some time before I can get this implemented.

thomasloupe avatar Sep 07 '22 03:09 thomasloupe

If you write up a quick contributing guide I don't mind taking a stab at it. I'm unintimidated by the codebase although it seems that the code is duplicated per platform. Is this done programmatically or manually?

jarommadsen avatar Sep 07 '22 03:09 jarommadsen

It's no problem. It's likely I can get around to it at some point very soon. The challenge is first knowing a message starts a thread, then placing every new comment inside of that thread.

I imagine we do a check to see if there is a timestamp for a thread, then gather all the messages up to the point where the timestamp for the thread is null, then foreach through them and add them to the thread. I just want to make sure I'm taking the best approach at this and want to give myself adequate time to think about the best implementation.

thomasloupe avatar Sep 08 '22 21:09 thomasloupe

I will more than likely begin work on this enhancement this weekend.

thomasloupe avatar Sep 09 '22 23:09 thomasloupe

@thomasloupe any updates? I would be interested in helping out!

junwoo091400 avatar Sep 22 '22 09:09 junwoo091400

No updates currently on this. I am still working on getting some other bugs and long-standing feature requests in. Once 2.3 is out for Linux/Mac, I can shift focus entirely toward this.

thomasloupe avatar Oct 30 '22 15:10 thomasloupe

I have begun work on this and am about halfway done through the Windows release. There are some nuances I need to work through - IE: once a thread is created, reply to the thread with additional messages, but I'm nearly finished with the enhancement, then I can move to testing.

thomasloupe avatar Nov 05 '22 07:11 thomasloupe

This feature has been completed and is now in Slackord v2.4! https://github.com/thomasloupe/Slackord2/releases/tag/v2.4

Appreciate the support for this enhancement request!

thomasloupe avatar Nov 06 '22 01:11 thomasloupe