Thomas J. Taylor

Results 21 comments of Thomas J. Taylor

I came across this same issue upgrading from 0.8.3 where our LMDB tables used `ByteBuffer.putLong( _rowId )` for the keys. When we tried to retrieve `_rowId=127` (`Byte.MAX_VALUE`), the new Comparator...

Attached Ontop query reformulation log. [ontop-query-plan.txt](https://github.com/ontop/ontop/files/12434227/ontop-query-plan.txt)

Thank you @bcogrel To clarify, there's nothing I can do in the R2RML/ODBA mapping file, I either need to modify the underlying database to add unique constraints to the table,...

@bcogrel when I add unique constraints directly to the tables, Ontop removes the self/left joins. However, I can't seem to get the Ontop Lens to work correctly (on tables with...

I had thought Ontop would use the Lens `baseRelation` to add the `uniqueConstraints` to the underlying table when planning the query. (without changing the Mapping) I've updated the R2RML Mapping...

@bcogrel for the Lens `foreignKeys`, does the `to` also need to refer to the Lens relation if it is defined? I currently have: ```json "to": { "columns": [ "\"ID\"" ],...

Thanks @bcogrel my question/issue has been resolved. I will do some tests with the foreign keys and if I find anything, I'll open a new issue for it.

I can test it out to confirm it resolves our issue. FYI. @rmbrad is the author of the original PR.

@thboileau We've been testing your merged fix for the past week and everything is working fine. Thanks