Thomas Heartman

Results 106 comments of Thomas Heartman

# PR update: ideas and solutions So this has been sitting for a bit without a clear solution. I have found a path that seems to work, but it feels...

I'd like to propose a few things: 1. Align APIs on how you PUT vs POST vs PATCH and what the different methods do. That means that PUT _should_ do...

Another point: I think we should [rename the "username" property of API tokens](https://linear.app/unleash/issue/UNL-101/deprecate-api-token-property-username) (and probably make it unique too). It's a token name and has nothing to do with users....

Follow-up on the comment around PUT. I've checked all (well, except one) of the PUT endpoints in the open source version. Here's what I found: ## /api/admin/stategies/{strategy} - PUT works...

Couple more things: 1. Remove the `environment` context field included in the Unleash context. While this is more up to each SDK, I'm sure there's places in Unleash proper where...

Haven't had a look at all of it yet, but did you delete the SDKs index file (from the docs) on purpose?

Nice work! This looks good to me, but I still don't know what problem it fixes, so I don't want to approve it just yet. The description says: > Bug...

Ah! That makes a lot of sense, actually. That's probably the issue here! I'll go have a look. Thank you!

I've had a look at this now, but can't quite make it work. You're more than likely spot on, but I'm not sure how to represent it. Could you give...

Hey, @ajdergute 🙋🏼 We haven't heard from you in a bit now and I see @sighphyre suggested a potential workaround for the backup file path. Did that work out for...