Thomas Frössman

Results 177 comments of Thomas Frössman

I don't let my Emacs save those files in the same directory as the original files,, There are just too many things which breaks beacuse of it..

Maybe so but tools should avoid writing temporary files outside of it's own data directories if possible. It's just an age old thing in emacs,, If the auto save backups...

But I suggest that you look into the `backup-directory-alist` , `auto-save-file-name-transforms` and `auto-save-list-file-prefix` (maybe others, I'm not sure, just quickly scanned my init file) to stop Emacs from storing temp...

A defcustom that can be used to enable/disable an addedDate column maybe?

This can either just be published as a new major version (not breaking any current users) or be published as a separate package, maybe by @guenhter just like aws-go-sdk-v2 is.

@guenhter Since this is a breaking change I would suggest adding a context argument to s3fs.New while you are at it so we get better canceling.

> @thomasf @guenhter What is the point of providing context to New? FS is supposed to be a long lived var, so it's not like you are going to be...

Adding the context at FS creation was suggested as a good solution during the io/fs proposal https://github.com/golang/go/issues/41190#issuecomment-690819876

I think you might to check the context for errors before new calls. Not sure if this is the best way to do it. ``` diff --git a/fs.go b/fs.go index...

Yeah I am not sure why the test doesn't fail unless I add it explicitly, maybe there is a problem somewhere else. It is probably a bug in the aws...