Thomas Eizinger
Thomas Eizinger
Yep, but that seems to be an error. We don't ever actually read such an input: https://github.com/thomaseizinger/create-pull-request/blob/master/src/getInputs.ts
So if I understand correctly, you want the action to fetch the number and url of the existing PR, even if it was not created? I think that makes sense....
PRs welcome!
I want to suggest to **not** couple this to the metric itself. In fact, even the unit itself seems to be unnecessarily coupled to the metric? We have some benchmarks...
> > For those particular ones, the metric is bits / s in the MBit range > > So the _Measure_ here would be `Throughput` as ` bits / s`....
> > What if I have multiple benchmarks in my project that all have a form of throughput but one of them is in `bits / s` and the other...
~Maybe "Throughput" could be named "dummy-throughput" instead? Or, "mock-throughput"?~ nvm, just read the thing about custom harnesses. Wouldn't it always make sense for users to create a custom measure? Perhaps...
Gnome 46 added a new WebDAV provider to Gnome Online Accounts: https://release.gnome.org/46/#upgraded-online-accounts-now-with-onedrive It would be nice if planify could pick those up automatically (and sync tasks from non-Nextcloud accounts too).
Currently, the `linux` implementation also hardcodes the use of smol. Would you see changing that in scope @mxinden ? Disclaimer: I am pretty unfamiliar with this crate and only had...
Is this because`rtnetlink` is only a dependency on Linux and therefore, the feature flag can't target it on other platforms?