Thomas Eizinger

Results 1888 comments of Thomas Eizinger

Another alternative could be to entirely replace the current `MemoryStore` with SQLite and by default, use the SQLite `:memory:` database. That would avoid the need for creating several layers of...

> Re-run `pb-rs` with the correct options to use `Cow` instead of `Vec`: I started with this an it yields a lot of compile errors (understandably). Those will all need...

> To actually make use of borrowed data in gossipsub for example, we need to defer encoding to the protobuf format for as long as possible. To achieve this, we'd...

No worries, it is an internal change so we can ship it at any point, doesn't need to go into the current release :)

If the data is borrowed, we don't need to `zeroize` it, I'd say? Whoever owns the data should zeroize it when it gets dropped :) Meaning, we can just match...

> If I am not mistaken, this would play nicely with your idea of splitting up the `UpgradeXXXbound` traits, right @thomaseizinger? It should yes. It would allow us to encode...

> Is there anything blocking this currently? I would like to help with this. Thank you! Nothing is per se blocking this but implementing it requires some bigger changes to...

So I think this is actually much easier than I initially thought. - We can introduce a new trait: `SecurityUpgrade` that we implement for noise and tls - In the...

Thanks for opening this! Whilst I don't think it is much of an issue in practice, I am happy to be stricter here :)

> If this is correct, what server does #4015 connect to, I presume Kubo for the time being? In the interop tests, we currently only test against a go-libp2p node....