Thomas Eizinger

Results 1888 comments of Thomas Eizinger

Thanks for outlining the approach. I am afraid that is a bit too big in scope for me to tackle.

What is the rationale for the synthetic project?

> TL;DR: The user's copy of their project is not guaranteed to be in a state amenable to valid rustdoc generation. To get it there we need a fresh lockfile...

The solution to https://github.com/obi1kenobi/cargo-semver-checks/issues/167 seems a bit excessive. In our workspace, this means recompiling the same dependencies for every crate because the individual synthetic crates don't share a `target` directory!

We could also state as a requirement that the repository needs to be versioned with `git`. You could then check for uncommitted changes and fail in that case. Assuming no...

> This can be changed today: the build should still obey cargo configuration. If you specify [`CARGO_TARGET_DIR`](https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-reads) (or the [equivalent config setting](https://doc.rust-lang.org/cargo/reference/config.html#buildtarget-dir)) then you can make all the crates share...

> > This can be changed today: the build should still obey cargo configuration. If you specify [`CARGO_TARGET_DIR`](https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-reads) (or the [equivalent config setting](https://doc.rust-lang.org/cargo/reference/config.html#buildtarget-dir)) then you can make all the crates...

> > > This can be changed today: the build should still obey cargo configuration. If you specify [`CARGO_TARGET_DIR`](https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-reads) (or the [equivalent config setting](https://doc.rust-lang.org/cargo/reference/config.html#buildtarget-dir)) then you can make all the...

Actually, no, because it still uses a different lockfile.

> > In our workspace, this means recompiling the same dependencies for every crate because the individual synthetic crates don't share a target directory! > > This can be changed...