Thomas Eizinger
Thomas Eizinger
I agree that this lifetime should go away. The discussion around that is in https://github.com/testcontainers/testcontainers-rs/issues/386. I don't want to just remove it without the requirements around creation and removal of...
Sorry for the late review, this will need to be updated to resolve the merge conflicts.
> I would assume that CLI implementation is around for _historical reasons_ but I don't see any benefits of keeping it around in the long term. Correct, it was the...
> Do you maybe know why would it fail? Can't think of anything either, sorry.
> Hi @thomaseizinger I created this in progress pull request to validated my understanding. Could you please take a look and let me know if what I am doing makes...
I have never heard of `docker pause` but it seems like a reasonable thing to implement so I am gonna accept a PR that adds a `pause` and `unpause` API...
> Should we introduce this in the version after #78? The version that includes #78 only would then error on `/webrtc` instead of interpreting it as the browser-to-browser protocol. Might...
Still need to test this properly.
> Resolves: #4290. @jamilbk I am optimistically marking this as resolving the above issue. Given that we can't reproduce directly why it happens, this is a bit of a gamble....
> I'm probably not understanding something, but can't we send relay candidates at the start and just wait 2 seconds to use them if holepunching fails? The difference here is...