Thomas Eizinger

Results 1887 comments of Thomas Eizinger

> Closing as #133 will land soon! :) I had it linked to the PR already :D

If we end up merging https://github.com/Restioson/xtra/pull/160, I am gonna iterate on this design again. I think it would be a step backwards to introduce a "ref count policy" again just...

One alternative idea to this would be to retain the `Sender` and `Receiver` newtypes but implement `Deref` on them so we don't need to forward all the methods.

> I think this will need to be rebased or updated now that #160 has been merged Yep, I'll need to think about a new design here.

So after thinking about this more, I think it is overall better to actually re-introduce a ref-count policy with this PR. Here is my thinking: I am currently trying to...

Does the above sound reasonable to you @Restioson ?

> > except that we would be introducing circular references between the address and the send_future module > > Is this a problem? I don't think this will be a...

Okay, this is ready for another review @Restioson! I've integrated #162 into here because the merge conflicts would have been insane. I also updated the PR description to be an...

All dependent PRs have been merged and feedback has been addressed :)

Would appreciate another review here @Restioson :)