Thomas Eizinger

> > The problem domain we have here is basically the same as `serde`'s, thus I think the ideal solution might be a visitor pattern with an abstract data model....

> 👍 for not adopting `serde`. Thanks for walking me through this. Appreciate the elaborate post above. > > I like the idea of a single `EncodeMetric` trait which is...

> > With saying that, could we get away with having an enum of all metrics and store that without boxing? :) > > Unfortunately not. Or I don't know...

> > So a `Family` could just contain the enum again, right? It is a recursive structure like `serde_json::Value`. > > Correct. > > > Do we need to be...

> While I do see value in users being able to bring their own metrics, I don't think users will bring their own output format. Thus we can likely get...

> > While I do see value in users being able to bring their own metrics > > I'm probably missing something here, but this doesn't (immediately) make sense to...

> @thomaseizinger > > > > I'm probably missing something here, but this doesn't (immediately) make sense to me. Prometheus metrics are types, not traits. A user type wouldn't _implement_...

Thanks for opening an issue! I don't recall whether this on purpose or just an oversight. @yottabytt can you add something to this? I think it should be fine to...

> Looking forward to have this merged. Alternatively the `inspect` method could be made public for more flexibility. This is unlikely going to happen as it would be a big...

Hmm, including this was actually on purpose. However, I've since pondered over a different API and wrote up https://github.com/testcontainers/testcontainers-rs/issues/386. That would make this obsolete and also remove this lifetime.