Thomas Eizinger

Results 1888 comments of Thomas Eizinger

Just got this while I had debug logging on, might be a race condition with DNS control: ``` 2024-10-04T01:28:26.442794Z INFO firezone_telemetry: Stopping telemetry 2024-10-04T01:28:26.443460Z DEBUG reqwest::connect: starting new connection: https://o4507971108339712.ingest.us.sentry.io/...

> Might be... I thought I just fixed that though lol Oh, I might not have been on latest `main`.

Fixed in https://github.com/firezone/firezone/pull/7109.

I ran into this yesterday too. I wanted to inline `connlib-shared` - which just contains message types at the moment - into `firezone-tunnel` but that would have coupled the gui-client...

I think it makes sense to have a crate for simple types like `ResourceId`. You'll have to handle that in the GUI and otherwise you have to duplicate them.

I attempted this in https://github.com/firezone/firezone/pull/6919, I think it worked out well.

We removed this log in #7326. Most likely it just happened because we started the GUI without the service so the ID wasn't present.

> If that bug and the one with `cargo sort`s own multiline comment are fixed, I'm happy to publish another release :) Is this still the latest or has there...

> I believe that alerting based on metrics is the preferred way over logs. The former are cheap and structured, the latter are expensive and unstructured. Is that universally true?...

> I believe those events are from the server side, right? Correct, they concern the server only.