Thomas Eizinger

Results 1888 comments of Thomas Eizinger

This is still an issue. I think the problem is that we create the tag only on releasing but at that point, the artifact has already been built, so it...

Thank you for the bug report! We also recently identified this and are already working on a fix. See https://github.com/algesten/str0m/pull/663. We expect to have this resolved early next week.

> I also tried debugging this with xdp-dump from xdp-tools, but it complains that the loaded XDP program does not have any BTF debug information present. Is there a way...

> But I think you can just update the existing panic handlers we have in the examples to be conditional on target_arch and remove default-members. > > Would you like...

I called it "no-op" because that is essentially what it is compared to crates like `panic-abort` which call into intrinsics. In my experience with eBPF, code that actually wants to...

So I sent a bunch of PRs. Weirdly enough, I couldn't replicate in your repo what I have working in mine in regards to removing `default_members`. I don't need it...

Aha! What we can do is the following: ```diff diff --git a/examples/aya-tool/myapp-ebpf/src/main.rs b/examples/aya-tool/myapp-ebpf/src/main.rs index 1892359..31b4ace 100644 --- a/examples/aya-tool/myapp-ebpf/src/main.rs +++ b/examples/aya-tool/myapp-ebpf/src/main.rs @@ -1,5 +1,5 @@ -#![no_std] -#![no_main] +#![cfg_attr(target_arch = "bpf", no_std)]...

What do you mean how does it build for me? Without the `main` stub, it doesn't build unless you build with `--target bpfel-unknown-none`. That is the issue I'd like to...

> Clarifying further: you said at the top of this issue that you opted for that `panic_halt` crate and removed default-members. What I'm asking is: how does that work, given...

Thinking more about it, I think those changes can't actually be meaningfully separated as they are too intertwined: - Feature-gating the `panic_handler` on `target_arch = "bpf"` only really makes sense...