Thomas Eizinger
Thomas Eizinger
A re-export of `PeerId` seems fine to me, yes :)
> The issue with this is that it implicitly assumes a left-to-right parsing approach for what it means to convert a multiaddr into a `SocketAddr`. I think this is the...
`Multiaddr` is a very fundamental crate to the Rust libp2p ecosystem. I am a bit hesitant to include a lot of convenience functions in here if it can be implemented...
Fine with me!
Where in the provided snippet do you read that an empty address is not allowed?
> Doesn't "+" mean 1 or more? Ah yes, I didn't realize that was actually a regular expression.
We could deprecate the `Multiaddr::empty` function and replace it with a `Multiaddr::new(Protocol)` one.
> What's the motivation behind this? More test coverage is always good, but I haven't seen a lot of problems in this part of the stack. The idea was sparked...
I just came across https://github.com/ryankurte/cargo-binstall which might be useful for other people interested in this feature.
It might be best to put the entire cert in an env var for now as we can't control the randomness for a new cert very well in the current...