webmail-linker icon indicating copy to clipboard operation
webmail-linker copied to clipboard

Feature Request - composer

Open tolzhabayev opened this issue 11 years ago • 12 comments

Make it composer compatible and publish it on packagist

tolzhabayev avatar Jul 23 '14 08:07 tolzhabayev

I'm working on this, but the problem is that I'm trying to avoid putting composer.json into the root of the repository, because it belongs in src/php/composer.json. That however doesn't seem to be possible with Composer.

thomasbachem avatar Jul 23 '14 08:07 thomasbachem

I guess it's mandatory to have composer.json in the root. I don't see why it has to be in src/php/composer.json unless you want to make it cross-language which is not a common practice. Normally you will have each repository for specific language, more or less as a bundle which can be easily loaded with composer.

Anyway nice list, keep it updated :)

tolzhabayev avatar Jul 23 '14 12:07 tolzhabayev

I just talked to seldaek from Composer, and he confirmed that this isn't possible indeed.

I think it makes no sense to have multiple repositories if the language libraries are mostly about 20-50 lines of code each – that would make things a lot more complicated. I prefer having them in src/[lang]/.

I'll decide on this soon ;).

thomasbachem avatar Jul 23 '14 12:07 thomasbachem

I would like to build a JavaScript / node.js module, but I think we have the same problem there.

Have you thought about creating a GitHub organisation with one repository for the JSON file and n other repositories for the different implementations?

sebbo2002 avatar Jul 23 '14 23:07 sebbo2002

@sebbo2002 I thought about that, but I'm really not sure about it.

Another disadvantage would be the split attention/watchers/stares between the different repositories...

thomasbachem avatar Jul 24 '14 09:07 thomasbachem

Another advantage would be, that every developer would be able to maintain his implementation (branches, tags, downloads, etc).

sebbo2002 avatar Jul 24 '14 10:07 sebbo2002

Yeah, but honestly, we're talking about code that will usually be around 20-100 lines. I'm not sure one needs fancy branches for that :D.

Having two repositories to make Webmail Linker work makes using it more complicated – we would need to use submodules for the config or the user needs to check out two repositories, which is also very uncommon. How would you do it?

thomasbachem avatar Jul 24 '14 10:07 thomasbachem

I uploaded my prototype here. Before I create the tarball for npm I copy the latest JSON from your repository, so it's always bundled and can easily updated via npm/bower. New versions could be created automatically, when the JSON gets updated.

  • easy installation process (for example npm install webmail-linker)
  • update via packet manager (npm, bower or whatever)

sebbo2002 avatar Jul 24 '14 12:07 sebbo2002

I'll decide on this soon ;)

Any news on this…? ;)

sebbo2002 avatar Mar 31 '15 08:03 sebbo2002

+1 I'd love to install this repository via bower. I don't see a problem here. Every modern packet manager expects the configuration files in the root folder (bower, npm, composer).

davidgorges avatar May 11 '15 17:05 davidgorges

https://github.com/MadaManu/angularjs-maillinker - the AngularJS flavour of this. Maybe we can integrate somehow at some point. I have registered this one on bower. I will update with documentation soon.

MadaManu avatar Jul 23 '15 23:07 MadaManu

As a workaround you can add this to your composer.json to install webmail-linker via composer:

{
   "type": "package",
   "package": {
      "name": "webmail-linker",
      "version": "0.1",
      "source": {
         "url": "https://github.com/thomasbachem/webmail-linker",
         "type": "git",
         "reference": "origin/master"
      }
   }
},

pascal-hofmann avatar Aug 02 '16 16:08 pascal-hofmann