themer icon indicating copy to clipboard operation
themer copied to clipboard

Suggestions to improve apply theme

Open gossi opened this issue 5 years ago • 4 comments

Hello 👋

Happily using your plugin and have some suggestions to improve it regarding the apply theme functionality. That mostly happened because I run the plugin, applied a theme and nothing happened.

  • Apply to document (not only the current page, which is what I'd need)
  • Remember the choice where the theme change should happen (I for my given use case wouldn't use selection at all - though it is always the default)
  • Only make the selection choosable if there IS a selection

I wouldn't mind sending a PR for that. Looking at the repo it looked more like the dist code rather than the dev code. Happy to hear how I can help out.

gossi avatar Jan 05 '20 15:01 gossi

Hey @gossi, I am working on all of this for the next release! Stay tuned and thanks for your suggestions.

thomas-lowry avatar Jan 14 '20 12:01 thomas-lowry

I've also run into the issue of running the plugin to apply a theme and nothing happening – @gossi how did you get around it/fix it?

eholder24 avatar Jan 14 '20 17:01 eholder24

@eholder24 Are the styles published? I recorded a video that walks through the setup: https://youtu.be/aM8SkksBy3Y

thomas-lowry avatar Jan 14 '20 17:01 thomas-lowry

Yes, they were published...but I ended up deleting the themes and starting over with two separate files and seems to be working now. Very likely I did something wrong when creating the two themes from the same doc with nested style names

eholder24 avatar Jan 14 '20 18:01 eholder24