expo-image-editor icon indicating copy to clipboard operation
expo-image-editor copied to clipboard

Published 20 hours ago • verified publisher icon thomas-coldwell

Make it stable

Open innonguyen opened this issue 3 years ago • 2 comments

Dear Thomas,

I think you should includes and fix something to make it stable version. Here're what I found:

  1. These following dependencies should not be devDependencies because your library won't work without it. You should keep it in list of dependencies.
  • expo-image-manipulator
  • expo-gl
  • recoil
  1. ImagePicker.requestCameraRollPermissionsAsync() is deprecated in favour of ImagePicker.requestMediaLibraryPermissionsAsync()

You can replace it in your home instruction in readme file.

Hope it helps

innonguyen avatar Oct 21 '21 16:10 innonguyen

True @innonguyen . this need to be adjusted I had to install those Libary one after the other

Joshmatjjen avatar Dec 20 '21 21:12 Joshmatjjen

I agree that recoil should definitely be in the dependencies. However, expo-gl and expo-image-manipulator are already listed in peerDependencies. That does mean that you need to install those yourself, but that's kind of what peerDependencies is for. The Readme should probably call out that you need to install those yourself though. I submitted a PR to add recoil and react-native-gesture-handler to dependencies.

ajenkins avatar May 27 '22 22:05 ajenkins