expo-image-editor icon indicating copy to clipboard operation
expo-image-editor copied to clipboard

feat: option translate labels

Open RodriguesCosta opened this issue 4 years ago • 4 comments

resolve #17

What do you think of this implementation, so it can be translated into any language!

RodriguesCosta avatar Apr 26 '21 21:04 RodriguesCosta

Thanks for the PR! Agreed this is definitely needed to support multiple languages. Just having a look through your code and I see you have put the variable bits of text into state - was this done on purpose over just passing them down as props from the parent component?

thomas-coldwell avatar May 05 '21 12:05 thomas-coldwell

I changed textTranslateOptions to customLabelsOptions.

I found it easier to use a state than to pass it directly as property.

RodriguesCosta avatar May 05 '21 14:05 RodriguesCosta

Are you going to merge this? :)

mmelilli avatar Jun 22 '21 07:06 mmelilli

Hi just wanted to ask when this is going to be merged ?

jakobsuckow avatar Oct 18 '22 16:10 jakobsuckow