SSHKeyDistribut0r icon indicating copy to clipboard operation
SSHKeyDistribut0r copied to clipboard
verified publisher icon thomai

implement csv table with logs

Open nickolay-github opened this issue 5 years ago • 3 comments

I decided to participate in open source, I hope after 4 years this enhancment issue https://github.com/thomai/SSHKeyDistribut0r/issues/7 is still relevant :)

I added the output of messages to the csv file which is easy to navigate

Perhaps you meant the table output to the console

If so, please let me know - I will redo

nickolay-github avatar Nov 19 '20 20:11 nickolay-github

Thanks a lot for the pull request!

Could you please update your changes a bit regarding the following change requests?

  • I suggest to have a CLI parameter to provide a file path for the exported CSV file (using argparse)
  • If the CLI parameter is not set, the results should not be exported (I think most of the people do not need such a file)
  • If you want to cover #7, the output needs to be formatted as a table (on the command-line). This issue is not about exporting a CSV file. I am not saying that your idea about exporting a CSV file does not make sense. I really appreciate that feature as well!

thomai avatar Dec 23 '20 22:12 thomai

Thanks for the feedback!

I agree with the points, I will refactor the PR based on the comment points

nickolay-github avatar Jan 04 '21 18:01 nickolay-github

Completed in another pull request - https://github.com/thomai/SSHKeyDistribut0r/pull/22

nickolay-github avatar Mar 15 '21 22:03 nickolay-github