Thomas Haller

Results 99 comments of Thomas Haller

that was very useful. So many plunders :) Thank you!

@mjrasobarnett it seems that `nm_connection_diff()` doesn't have the correct gtk-annotations for the `@out_settings` argument. So, I think it will be hard (impossible?) in the current form to call it. See...

I fail to annotate `nm_connection_diff()` in a way that works with pygobject. Something like ``` @out_settings: (type GLib.HashTable(utf8,GLib.HashTable(utf8,utf8))) (out) (allow-none) (transfer full): ``` should work, but it doesn't. that means,...

> I was wondering if someone might be able to offer any guidance on what might be the issue here, and how I could observe the state perhaps to see...

it tells you that NM thinks that the properties `"802-3-ethernet.s390-options,802-3-ethernet.mac-address-blacklist"` differ. This is also what `nm_connection_diff()` probably would tell you. There is a bug here somewhere.

this is indeed very likely a bug in NetworkManager. Still, maybe the role should try to workaround it. The roles main goal is to create a well-define profile. To always...

from the information here I don't understand who/where the `[ethernet]` setting gets added. I agree with Gris, that the infiniband profile probably should not have such a setting, but where...

the error message comes from https://github.com/linux-system-roles/network/blob/main/library/network_connections.py#L1824, but it's not clear why. Can you edit the printed message to also show `li_mac` and `li_ifname`?

> Overall looks good and an improvement. > > There might be one problem still... I would address those problems later in a separate commit.

> > There might be one problem still... > > I would address those problems later in a separate commit. https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1414 will add a helper function to libnm to make...