Hecke.jl

Hecke.jl copied to clipboard

before I forget

thofma

Random test failures in `NfOrd/PicardGroup.jl`

3

observed in the downstream tests in AA in https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/9224253991/job/25379194623?pr=1715#step:7:169 ```julia Error During Test at /home/runner/.julia/packages/Hecke/SZzwT/test/NfOrd/PicardGroup.jl:61 Got exception outside of a @test AssertionError: $(Expr(:escape, :(nbits(pp) < 10000))) Stacktrace: [1] macro expansion...

lgoettgens

Multiplication in local fields spends most of the time in multiplying ramification index with the valuation

2

might be worth investigating at some point @joschmitt ``` ╎ ╎ ╎ ╎ ╎ ╎ 118 @Hecke/src/LocalField/Elem.jl:648; mul!(c::Hecke.LocalFieldElem{QadicFieldElem, Hecke.EisensteinLocalField}, a::Hecke.LocalFieldElem{Qadi… ╎ ╎ ╎ ╎ ╎ ╎ 118 @AbstractAlgebra/src/Fraction.jl:337; *(a::Int64, b::QQFieldElem)...

simonbrandhorst

``` julia> padic_field(3)(0) O(3^64) julia> qadic_field(3,4)[1](0) 0 ```

simonbrandhorst

Replace some `setprecision!(::ParentObject)`

1

This replaces many `setprecision!(::ParentObject)` calls by `with_precision` blocks. Also removes `prime_field` in the context of local fields.

joschmitt