Tim Hockin

Results 467 comments of Tim Hockin

https://github.com/kubernetes/kubernetes/issues/124540#issuecomment-2081009699 suggests we DO need `hostAlias.IP` done the same way

It's better to do it as one, IMO, so *if* we have to rollback, we gwt both.

Ugh, those bugs. I guess I agree - `// +default=""` is probably the compatible option.

Could we validate non-empty on CREATE, but allow empty during UPDATE?

Yeah, I guess I was trying to convince myself it was OK, similar to the IP validation eventuially disallowing leading zeros in octets.

Yes. I don't have any equivalent bugs on-hand, but I bet someone somewhere has done the same sort of mistake.

We should comment both of these that they are effectively required, but dues to backward compatibility are allowed to be empty, and if they are empty they are meaningless.

Hold up, it looks like `hostAliases.ip` *is* validated, so it can be `// +required`. ``` $ k replace -f /tmp/d.yaml The Deployment "hostnames" is invalid: spec.template.spec.hostAliases[0].ip: Invalid value: "": must...

Also, we plan to backport to 1.30 branch, right?