browserify-ftw icon indicating copy to clipboard operation
browserify-ftw copied to clipboard

Update esprima to version 3.1.3

Open alicoding opened this issue 8 years ago • 7 comments

I have to fix this broken test test/fixtures/use-strict-without-semicolon.js Since using use strict it was throwing an error when parsing the code about missing semicolon here

closes #21

alicoding avatar Jun 04 '17 15:06 alicoding

I also added package-lock.json which is part of npm@5

alicoding avatar Jun 04 '17 15:06 alicoding

I also added a test here :)

alicoding avatar Jun 04 '17 15:06 alicoding

Hi, thanks for the work I will review when I get a chance. In the meantime please remove all unrelated changes:

  • lots of whitespace changes (please undo)
  • package-lock.json is not necessary for this change, please remove

Also please stick to the range scheme I'm using for dependencies in the package.json, i.e. don't use ^, but ~ instead.

Thanks

thlorenz avatar Jun 05 '17 04:06 thlorenz

Done :)

alicoding avatar Jun 05 '17 14:06 alicoding

Many thanks :)

I merged and published as 1.0. I'd love to see some docs regarding the moveStrictWanted feature you added. Please when you have some time add that.

I also made you collaborator.

So in the future you can merge changes to master after we agree on a PR, following this guide. I will then version and publish to npm.

Thanks.

thlorenz avatar Jun 05 '17 16:06 thlorenz

Actually, I did not add that feature, but I don't mind adding documentation for that :) and thanks!

alicoding avatar Jun 05 '17 17:06 alicoding

Ah ok, got confused since there were some changes around there ... But yeah any help here would be greatly appreciated :)

thlorenz avatar Jun 05 '17 17:06 thlorenz