Parker Higgins
Parker Higgins
This is amazing and greatly appreciated. I do want to review it with some care but I anticipate I will probably merge all these commits, maybe with some very minor...
I would like to merge this and I'm very sorry it took so long! (I'm glad you saw that that I'm back in it, since I've been at Recurse Center...
Actually I have two questions, if you don't mind! - the `__get_subclasses` function in `__init__.py` has `[T]` which I think is a [type parameter list](https://docs.python.org/3/reference/compound_stmts.html#type-params), new in 3.12? Sorry, I'll...
I spotted one teeny thing with the keyword listing, and it looks like the CI is stumbling on something having to do with the `matches_url` changes, on some but not...
OK I've got a clearer picture of it. I think it's failing on every test that uses the `by_url` path, and I think it's because `BaseDownloader` is being included as...
More context as I'm figuring it out: I think the issue is that the `supported_downloaders` comprehension wants to filter out downloaders that have not implemented their own `matches_url` function. Instead,...
Alright, how'd I do? CI won't mark as "passing" because it doesn't have access to my secrets in your fork, but I can independently confirm it works on NYT puzzles....
I agree with all the notes, thank you for your attention on this! Please do pick over that change with the `ruff format` and then I think we're good to...
Interesting. Get Latest works for me on two machines but I've also not been able to get the page to work in the browser for a while now. Newsday is...
I don't want to jinx it but this appears to have calmed down a bit since opening the issue. Will continue to monitor...