Nic Crane
Nic Crane
I'm closing this PR for now as it was handed over to me to take a look at, but I don't think I'm going to end up with time to...
This has been removed as it currently results in an error - see https://github.com/apache/arrow/pull/13786#discussion_r936124019
This PR now also implements the `.names` argument.
> This is so close! I'm definitely in favor of deferring `filter()` and `summarise()` to another PR (although it will be confusing if they are not implemented before the next...
> I think you nailed it - the `mutate()` tests are about matching dplyr's functionality (e.g., they will fail if dplyr changes something and makes this code out of sync);...
@paleolimbot I've updated the tests as per your and Neals' useful suggestions. Mind giving it another review now?
In addition to `pitrou`'s comment on retrying `arrow::write_feather()` and checking the CPU activity, if you like, you could generate more diagnostic information by running the code with the C++ debugger...
@romainfrancois Jon suggested I ask you if there is any batching happening in the R data frame to Arrow table conversion? If not, that could explain what's happening here.
> @thisisnic would you be willing to review? I've given it a look over and other than a couple of small comments on stylistic matters, it looks good to me...
> This is ready to review/merge. Failed jobs are unrelated to this change. > > @thisisnic Could you test the latest change to confirm that this approach fixes the original...