Luke Watts

Results 169 comments of Luke Watts

That's right @ThakurKarthik, you'd need to extend the Theme definitions in each of these locations to add an `alert` property: * https://github.com/ONEARMY/community-platform/blob/master/src/themes/project-kamp/styles.ts#L199 * https://github.com/ONEARMY/community-platform/blob/master/src/themes/precious-plastic/styles.ts#L199 * https://github.com/ONEARMY/community-platform/blob/master/src/themes/fixing-fashion/styles.ts#L199 Future work would be...

This looks great @ThakurKarthik, thanks for addressing the feedback ✨

@ThakurKarthik I've approved the approach, however you will need to address the automated checks before this will be mergeble. Consider squashing the 3 existing commits into a single commit that...

Thanks @ThakurKarthik, I have been away from the internet for a few days. Let me take a look and get back to you.

@ThakurKarthik, based on the failing tests would you be able to format the code? You can use the `yarn format` command to do this.

These test failures look consistent @ThakurKarthik, but I haven't yet been able to recreate them locally. I will take a further look at this but it won't be until the...

Thanks @ThakurKarthik, I ended up pushing a branch with your work and adding a commit to adjust the Cypress selector to bypass the test failure. I have no good answers...

@all-contributors add @ThakurKarthik for code

It may be worth considering an alternative visual approach to communicate the various states. The contrast difference between the Gray and Yellow is not very apparent, especially if you: *...

Thanks for raising this @kfern 🙇🏻 I will take a look at this over the next weekend. Very interested in improving the test coverage on this project!