vscode-rsync icon indicating copy to clipboard operation
vscode-rsync copied to clipboard

remote paths ending in ":" get translated into ":/"

Open hellertime opened this issue 2 years ago • 1 comments

just tried a small setup with the remote path ending in ":", this got converted into ":/" and with "deleteFiles: true" tried to remote delete my machine (unix file permissions scoped the damage to just my home dir)

hellertime avatar Mar 11 '23 01:03 hellertime

Wanted to add it seems this also happens for the "localPath", so if you have "localPath: /foo/bar" you run rsync like "rsync -... /foo/bar/ remote@...", adding that "/" to the local path means rsync won't create a remote directory and the "delete" then has an entirely different meaning

hellertime avatar Mar 11 '23 01:03 hellertime