unity-sdk icon indicating copy to clipboard operation
unity-sdk copied to clipboard

Including Starscream as dependency twice

Open coding-velociraptor opened this issue 1 year ago • 2 comments
trafficstars

Hey,

I noticed that Starscream is included into the package twice:

  1. In MetaMaskDependencies.xml leads an entry in the Podfile
  2. As Starscream.framework under /Plugins/iOS/iphoneos

In our setup, it fails the build. At the moment, we manually delete on of them. Wouldn't it better to only keep the first one?

XCode 15.3 OS X 14 (arm64)

Thanks.

coding-velociraptor avatar Apr 25 '24 13:04 coding-velociraptor

Will look at this soon, I don't remember getting duplicates in my build process but that's a good callout - are you using Unity 2021 by chance?

0xFirekeeper avatar May 13 '24 17:05 0xFirekeeper

We use Unity 2022.3.10f1 right now.

coding-velociraptor avatar May 15 '24 11:05 coding-velociraptor

Decided to remove the pod instead. After the next MetaMask upgrade might do the opposite. Thanks for the report, should be fixed here https://github.com/thirdweb-dev/unity-sdk/releases/tag/v4.13.3

0xFirekeeper avatar May 20 '24 16:05 0xFirekeeper