python-sdk icon indicating copy to clipboard operation
python-sdk copied to clipboard

An error occurs when `creating_batch` using the Python SDK.

Open warengonzaga opened this issue 2 years ago • 0 comments

The error occurs in the thirdweb\core\classes\erc_721.py file. TypeError: upload_metadata_batch() takes from 2 to 3 positional arguments but 5 were given

I checked that an error occurred in the code below.

batch = self._storage.upload_metadata_batch(
        [metadata.to_json() for metadata in metadatas],
            start_file_number,
            self._drop._contract_abi.contract_address,
            self._drop.get_signer_address(),
        )

Storage.upload_metadata_batch requires only two parameters, but four are entered in the code. (excluding self parameters)

Unnecessary parameters have been deleted from storage.upload_metadata_batch according to the error message.

And I checked that it works normally. The development team requests a revision of the library in this SDK.

image image

Reported from Discord by user.

Tagging @adam-maj to review the bug. Thanks!

warengonzaga avatar Aug 30 '23 01:08 warengonzaga