contracts icon indicating copy to clipboard operation
contracts copied to clipboard

Add auction winner check in collectAuctionTokens in EnglishAuctionsLogic.sol

Open goldnite opened this issue 2 years ago • 0 comments

There was no check for _msgSender() in collectionAuctionTokens. I have changed following line to check if the _msgSender() is auction winner. _winningBid.bidder != address(0) is not necessary because _msgSender() cannot be zero address.

  • original code
require(_winningBid.bidder != address(0), "Marketplace: no bids were made.");
  • suggested code
require(_winningBid.bidder == _msgSender(), "Marketplace: not auction winner.");

I have also changed term winning bidder to auction winner in the marketplace-v3.md.

goldnite avatar Dec 14 '23 22:12 goldnite