thinreports-generator icon indicating copy to clipboard operation
thinreports-generator copied to clipboard

Custom font

Open hidakatsuya opened this issue 6 years ago • 3 comments

Introduction

It has some different implementations from the official frozen specification thinreports/thinreports#5.

Status

  • [x] Implementation
  • [x] Manual test
  • [ ] Some code refactoring
  • [ ] Spec

Feature and Specification

See https://github.com/thinreports/thinreports-editor/pull/68

hidakatsuya avatar May 07 '18 18:05 hidakatsuya

Hey @hidakatsuya - is there any ETA on this?

I used the fallback fonts to get around Prawn::Encoding::UndefinedConversionError but they failed to activate given the font_family setting on the text boxes inside the tlf file.

To get around it, I had to replace Helvetica with Custom-fallback-font0 to allow 'smart quotes' and other UTF-8 items in generated PDFs (so as to force ttf files).

If there is some other way to get this working, that'd be great.

timeimp avatar Nov 16 '18 06:11 timeimp

@timeimp Sorry for the delay in getting back to you. Also, thank you for commenting.

Unfortunately, we have not yet decided on an ETA for this feature, and we need to discuss the specification for it as well.

In addition, the specification is being discussed in https://github.com/thinreports/thinreports/issues/5 (in japanese).

hidakatsuya avatar Nov 17 '20 12:11 hidakatsuya

@hidakatsuya No worries (and thanks for your response!).

If you need any help or movement on the spec front, I'm definitely glad to give input on thinreports/thinreports#5. Will set some time aside over the next month to add my 2c on this.

As I see it, being able to visually see the different fonts on board would be a massive plus for Thinreports.

That said, the spec definitely needs careful consideration with all the ways one might use fonts and the implications for rendering on local systems (yay!).

Thank you again!

timeimp avatar Nov 17 '20 12:11 timeimp