Windows - application icon is probably missing

[RadekCap]

After installation from MSI, there is this icon in the system menu:

This icon is probably default.

The application icon in the tray is correct one:

Tested on Windows 11.

[ursjoss]

~Possibly a duplicate of #81~

[ursjoss]

https://netbeans.apache.org/wiki/main/wiki/DevFaqExecutableIcon/

[ursjoss]

Option: Use rcedit to set icon (needs a windows machine, alternatively a linux machine with wine installed). Command to exchange the icon:

RCEDIT.EXE your_installer.exe /I icon_file.ico

Could be run in a github action job step, executing rcedit as shown above or optionally using a dedicated action: https://github.com/Bioblaze/rcedit-action.

In order to integrate it into the ant build:

<target name="replace-windows-icon" depends="build-launchers">
    <exec executable="RCEDIT.EXE" dir=".">
        <arg line="build\launcher\bin\${app.name}.exe /I branding\core\core.jar\org\netbeans\core\startup\${app.name}.ico"/>
    </exec>
</target>

Alternative to RCEdit, ReplaceVistaIcon.exe.

<target name="replace-windows-icon" depends="build-launchers">
    <exec executable="ReplaceVistaIcon.exe" dir=".">
        <arg line="build\launcher\bin\${app.name}.exe branding\core\core.jar\org\netbeans\core\startup\${app.name}.ico"/>
    </exec>
</target>
```