thingsboard-gateway icon indicating copy to clipboard operation
thingsboard-gateway copied to clipboard

Downstreaming changes to the Python SDK?

Open jelacious opened this issue 2 years ago • 7 comments

Would it be possible to downstream the changes made in the repository to the shared files of the Python SDK? Alternatively, is it possible to include those updated files as part of a "third party integration" in some neat way? I'd like to have the library be up-to-date and seeing as the Python SDK isn't actively being maintained right now I am unsure what to do.

From a maintenance point of view it seems a bit strange to include those files in this repository as well instead of specifying them as either a git submodule or including them via something like pip. I think a git submodule would be the neatest solution as then you can propagate updates very fast between the two repos, but updating the pip versions is also probably a good idea.

jelacious avatar Apr 25 '22 09:04 jelacious

Hi @jelacious, we will update these methods in Python SDK in the nearest future. Thanks for your interest in ThingsBoard IoT Gateway!

samson0v avatar Apr 26 '22 10:04 samson0v

Hi @jelacious, we updated these methods yesterday, so you can clone the newest version from the master branch. Also, there are some other fixes and improvements.

samson0v avatar Apr 27 '22 07:04 samson0v

Nice!

Will there be a bump in version on pip as well?

jelacious avatar Apr 27 '22 08:04 jelacious

@jelacious yes, but I don't know when exactly this will be done.

samson0v avatar Apr 27 '22 08:04 samson0v

Alright, thanks for the info! I'd suggest making the Python SDK repository a git submodule of this repository so that it will be easier to get updates between the two repositories in the future.

Thanks for the help! <3 Слава Украине!

jelacious avatar Apr 27 '22 09:04 jelacious

@jelacious we will discuss this suggestion, thanks. Героям слава!

samson0v avatar Apr 27 '22 11:04 samson0v

Hi @jelacious, we decided to use Python SDK as a base for Gateway, so all products will be in updated status.

samson0v avatar May 24 '22 09:05 samson0v