things.py icon indicating copy to clipboard operation
things.py copied to clipboard

fix today() failing if start_date is None - fixes #119

Open bkleinen opened this issue 11 months ago • 3 comments

simply added an "or today" to prevent result.sort from failing.

bkleinen avatar Mar 20 '24 10:03 bkleinen

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.32%. Comparing base (41f0112) to head (d48d7fe). Report is 82 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #120      +/-   ##
===========================================
- Coverage   100.00%   99.32%   -0.68%     
===========================================
  Files            2        3       +1     
  Lines          363      444      +81     
===========================================
+ Hits           363      441      +78     
- Misses           0        3       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 20 '24 10:03 codecov-commenter

@bkleinen Thanks for the pull request.

Two notes:

  1. To reproduce in Things, how do I make a task in Today where task['start_date'] is None?
  2. In Python, you can do datetime.datetime.today().date().isoformat().

mikez avatar Apr 17 '24 20:04 mikez

@bkleinen In case this got lost, I'd like to repeat the question from https://github.com/thingsapi/things.py/issues/119 and the comment above. If I don't hear back within a week, I'll close this.

mikez avatar Jul 31 '24 04:07 mikez

@bkleinen Closing this due to no answers coming back. Happy to open again once you return. (/cc @AlexanderWillner)

mikez avatar Aug 17 '24 11:08 mikez