thin-edge.io icon indicating copy to clipboard operation
thin-edge.io copied to clipboard

Bugs/958 messages missing when not connectd

Open abelikt opened this issue 2 years ago • 2 comments

Proposed changes

See https://github.com/thin-edge/thin-edge.io/issues/958 Make the related test connect during the test run and fix their assertions.

This is a draft until we have decided on how to continue with #958

Types of changes

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • [ ] Documentation Update (if none of the other choices apply)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

https://github.com/thin-edge/thin-edge.io/issues/958

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [ ] I have signed the CLA (in all commits with git commit -s)
  • [ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
  • [ ] I used cargo clippy as mentioned in CODING_GUIDELINES
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)

abelikt avatar Mar 02 '22 14:03 abelikt

This PR is open as we haven't decided on how to continue with https://github.com/thin-edge/thin-edge.io/issues/958

abelikt avatar Jun 09 '22 08:06 abelikt

This PR is open as we haven't decided on how to continue with https://github.com/thin-edge/thin-edge.io/issues/958

abelikt avatar Jun 09 '22 08:06 abelikt

Closing: too outdated

didier-wenzek avatar Nov 22 '22 09:11 didier-wenzek