thin-edge.io
thin-edge.io copied to clipboard
[CIT-466] Protoype & Draft : Use collectd for system test measurements
Proposed changes
This PR would enable performance measurements with collectd that one can run with pysys. So far it wasn't merged into main as it needs a different collectd configuration. It also wasn't clear if using collectd in thin-edge and using it for performance has side effects. Before merging, we should investigate to find out if we have sideefects.
Current state: prototype code with cloned changes from Michaels feature/CIT-466-collectd-recording branch
Types of changes
What types of changes does your code introduce to thin-edge.io
?
Put an x
in the boxes that apply
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Paste Link to the issue
https://cumulocity.atlassian.net/browse/CIT-466
Checklist
- [ ] I have read the CONTRIBUTING doc
- [x] I have signed the CLA (in all commits with git commit -s)
- [ ] I ran
cargo fmt
as mentioned in CODING_GUIDELINES - [ ] I used
cargo clippy
as mentioned in CODING_GUIDELINES - [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
Codecov Report
Merging #459 (0e76c18) into main (f463f01) will increase coverage by
0.04%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #459 +/- ##
==========================================
+ Coverage 63.02% 63.07% +0.04%
==========================================
Files 112 112
Lines 7007 7184 +177
==========================================
+ Hits 4416 4531 +115
- Misses 2591 2653 +62
Impacted Files | Coverage Δ | |
---|---|---|
tedge/src/cli/connect/common_mosquitto_config.rs | 97.46% <0.00%> (-0.16%) |
:arrow_down: |
tedge/src/cli/connect/command.rs | 0.00% <0.00%> (ø) |
|
tedge/src/cli/config/config_key.rs | 0.00% <0.00%> (ø) |
|
tedge_config/tests/test_tedge_config.rs | 88.19% <0.00%> (+0.11%) |
:arrow_up: |
sm/plugin_sm/src/plugin_manager.rs | 45.63% <0.00%> (+1.94%) |
:arrow_up: |
tedge_config/src/tedge_config.rs | 43.33% <0.00%> (+3.18%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f463f01...0e76c18. Read the comment docs.
Note: Before merging, we should investigate to find out if we have sideeffects (see description).
Closing as being no more a priority.